r248984 - Test fix

Kim Gräsman via cfe-commits cfe-commits at lists.llvm.org
Sun Oct 4 01:27:31 PDT 2015


On Fri, Oct 2, 2015 at 3:09 AM, Richard Smith via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
> On Thu, Oct 1, 2015 at 6:01 AM, Renato Golin via cfe-commits
> <cfe-commits at lists.llvm.org> wrote:
>>
>> Right, I reverted both commits on r249005. Please, let me know if you
>> need help testing on ARM before the next commit. This looks like it
>> could be tested on any 32-bit platform, though, so you should be able
>> to get it passing on ARM if you test and make it pass on x86.
>
>
> It looks like it's just failing because there's more than 10 metadata nodes
> in this test for your bot.
>
> +    // CHECK-INVARIANT: load {{.*}} !invariant.load ![[EMPTY_NODE:[0-9]]]
>
> ... should be
>
> +    // CHECK-INVARIANT: load {{.*}} !invariant.load ![[EMPTY_NODE:[0-9]*]]

Drive-by review: shouldn't that be [0-9]+ -- you require at least one, right?

- Kim


More information about the cfe-commits mailing list