[PATCH] D13373: Emiting invariant.group.barrier for ctors bugfix

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 2 11:07:22 PDT 2015


rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.

LGTM, but your commit message should be more descriptive than your current summary. Something like:

Ensure that the vptr store in the most-derived constructor is not behind an invariant group barrier. Previously, the base-most vptr store would be the one behind no barrier, and that could result in the creator of the object thinking it had the base-most vtable.


http://reviews.llvm.org/D13373





More information about the cfe-commits mailing list