[PATCH] D13339: Allow a ToolChain to compute the path of a compiler-rt's component.

Simon Atanasyan via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 1 06:29:31 PDT 2015


atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.


================
Comment at: include/clang/Driver/ToolChain.h:253
@@ -252,1 +252,3 @@
 
+  virtual SmallString<128> getCompilerRT(const llvm::opt::ArgList &Args,
+                                         StringRef Component,
----------------
Return `std::string` for consistency with other methods.


http://reviews.llvm.org/D13339





More information about the cfe-commits mailing list