[PATCH] D13100: [mips] Separated mips specific -Wa options, so that they are not checked on other platforms.

[Daniel Sanders via cfe-commits]

Hi,

Sorry for the slow reply. I'm a bit behind on cfe-commits and it seems I dropped out of the CC list so it didn't land in my inbox.

Do you mean something like this?:
	for (...) {
	  ...

	  switch (C.getDefaultToolChain().getArch()) {
	  default:
	    break;
	  case llvm::Triple::mips:
	  case llvm::Triple::mipsel:
	  case llvm::Triple::mips64:
	  case llvm::Triple::mips64el:
	    if (Value == "--trap") {
	      ...
	      continue;
	    }
	    break;
	  }
	
	  if (Value == "-force_cpusubtype_ALL") {
	    ...
	    continue;
	  }

	  ...

	  D.Diag(diag::err_drv_unsupported_option_argument)
	      << A->getOption().getName() << Value;
	}

If so, that sounds good to me.
 
> -----Original Message-----
> From: cfe-commits [mailto:cfe-commits-bounces at lists.llvm.org] On Behalf
> Of Joerg Sonnenberger via cfe-commits
> Sent: 24 September 2015 13:27
> To: cfe-commits at lists.llvm.org
> Subject: Re: [PATCH] D13100: [mips] Separated mips specific -Wa options, so
> that they are not checked on other platforms.
> 
> On Thu, Sep 24, 2015 at 10:22:29AM +0000, Daniel Sanders via cfe-commits
> wrote:
> > I'm thinking something like:
> 
> I think we really want to have an outer case, platform specific -Wa
> options are quite common. Only x86 is mostly getting by without them so
> far. I also think the switch is not that difficult to read.
> 
> Joerg
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits