[PATCH] D13134: [analyzer] Add keyboard shortcuts to report.html
Devin Coughlin via cfe-commits
cfe-commits at lists.llvm.org
Tue Sep 29 18:12:57 PDT 2015
dcoughlin added a comment.
Thanks for the patch! This looks very useful. What browsers does the JavaScript support?
One thing I noticed is that after immediately loading a new report page the 'j' and 'k' shortcuts don't work for me. In Safari, I get:
TypeError: null is not an object (evaluating 'document.location.hash.match(/Path\d+|EndPath/)')
Jumpkeyboard-shortcuts.js:3
onkeydownkeyboard-shortcuts.js:29
After clicking on the location link in the summary the keys **do** work. (I guess this has to with the # in the location?) Would it be possible to make these navigation keys go to the end of the path after the page has loaded but before the user has clicked on the location link?
================
Comment at: tools/scan-build/keyboard-shortcuts.js:24
@@ +23,3 @@
+ K: 75,
+ SLASH: 191
+}
----------------
Will this work on international keyboards where ? is not Shift + '/'? (E.g., AZERTY or QWERTZ?)
Repository:
rL LLVM
http://reviews.llvm.org/D13134
More information about the cfe-commits
mailing list