[PATCH] D13081: [clang-tidy] Implement FixitHints for identifier references in IdentifierNamingCheck

Beren Minor via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 29 07:29:40 PDT 2015


berenm updated this revision to Diff 35972.
berenm added a comment.

Address the latest comments, as well as useless code removal.

- Only the start of the token range is stored, so there is no need to care about the end of the range. Remove the code that was trying to match the end of the range (template, nested name).
- Add some spaces in test cases (destructors, templates) just to be sure that everything works as expected.
- Add a missing CHECK-FIXES in the test case on the abstract_class destructor.


http://reviews.llvm.org/D13081

Files:
  clang-query/tool/CMakeLists.txt
  clang-tidy/misc/UnusedRAIICheck.h
  clang-tidy/modernize/CMakeLists.txt
  clang-tidy/modernize/MakeUniqueCheck.cpp
  clang-tidy/modernize/MakeUniqueCheck.h
  clang-tidy/modernize/ModernizeTidyModule.cpp
  clang-tidy/readability/IdentifierNamingCheck.cpp
  clang-tidy/readability/IdentifierNamingCheck.h
  clang-tidy/tool/run-clang-tidy.py
  docs/clang-tidy/checks/google-build-explicit-make-pair.rst
  docs/clang-tidy/checks/misc-unused-raii.rst
  docs/modularize.rst
  test/clang-tidy/Inputs/readability-identifier-naming/system/system-header.h
  test/clang-tidy/Inputs/readability-identifier-naming/user-header.h
  test/clang-tidy/modernize-make-unique.cpp
  test/clang-tidy/readability-identifier-naming.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D13081.35972.patch
Type: text/x-patch
Size: 35505 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150929/06da2217/attachment-0001.bin>


More information about the cfe-commits mailing list