[PATCH] D13166: Create modernize-make-unique check.
Manuel Klimek via cfe-commits
cfe-commits at lists.llvm.org
Tue Sep 29 02:21:04 PDT 2015
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
apart from the comment, LG
================
Comment at: clang-tidy/modernize/MakeUniqueCheck.cpp:67-70
@@ +66,6 @@
+ SourceLocation ConstructCallEnd;
+ if (LAngle == StringRef::npos) {
+ ConstructCallEnd = ConstructCallStart.getLocWithOffset(ExprStr.size());
+ Diag << FixItHint::CreateInsertion(ConstructCallEnd,
+ "<" + Type->getAsString() + ">");
+ } else {
----------------
Please add a comment what this does (in which cases do we want to insert the type).
http://reviews.llvm.org/D13166
More information about the cfe-commits
mailing list