[PATCH] D13128: Fix backend crash on multiple close of stdout.

Yaron Keren via cfe-commits cfe-commits at lists.llvm.org
Sat Sep 26 01:22:39 PDT 2015


yaron.keren added a comment.

Hi Dan, it makes sense that output streams should not usually be mixed together, especially if one is binary as you write.
This may or may not be a problem depending on what the user really wants. He may want to mix the outputs for whatever purposes or it may usually be a user error. 
In any case, that's not how clang deal with usage or even internal unexpected errors. It asserts, print error messages but does not crash on purpose. Having clang crash here does not seem like a good solution and will result in this issue continue to surface again.


http://reviews.llvm.org/D13128





More information about the cfe-commits mailing list