[PATCH] D13090: [clang-tidy] IdentifierNamingCheck should only emit warnings when declaration or usage is outside of macros

Beren Minor via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 24 13:10:50 PDT 2015


berenm added a comment.

This will also disable all warnings for declaration / usages outside of the main file.

It might be better to disable the warnings and fixes whenever a macro is involved (in the declaration or any usage), but at least keep the warning across files, even if we don't offer fixes. I think the most common use-case will be to have some declaration in a header file and usages in multiple source files, and in this case warnings are interesting.

I'm assuming here that "main file" in clang tooling framework means the .cpp file from which the ast is built.


http://reviews.llvm.org/D13090





More information about the cfe-commits mailing list