[PATCH] D13052: Add NamingStyle option to modernize-loop-convert.

Angel Garcia via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 24 05:01:40 PDT 2015


angelgarcia updated this revision to Diff 35608.
angelgarcia added a comment.

> No need to check the length. `endswith` handles this itself.


I am checking that it is strictly greater than one, because we don't want an empty identifier after removing the "s".


http://reviews.llvm.org/D13052

Files:
  clang-tidy/modernize/LoopConvertCheck.cpp
  clang-tidy/modernize/LoopConvertCheck.h
  clang-tidy/modernize/LoopConvertUtils.cpp
  clang-tidy/modernize/LoopConvertUtils.h
  clang-tidy/modernize/ModernizeTidyModule.cpp
  test/clang-tidy/Inputs/modernize-loop-convert/structures.h
  test/clang-tidy/modernize-loop-convert-basic.cpp
  test/clang-tidy/modernize-loop-convert-camelback.cpp
  test/clang-tidy/modernize-loop-convert-extra.cpp
  test/clang-tidy/modernize-loop-convert-lowercase.cpp
  test/clang-tidy/modernize-loop-convert-negative.cpp
  test/clang-tidy/modernize-loop-convert-uppercase.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D13052.35608.patch
Type: text/x-patch
Size: 106801 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150924/21b789a3/attachment-0001.bin>


More information about the cfe-commits mailing list