[Diffusion] rL248367: clang-format: Add initial #include sorting capabilities.

Daniel Jasper via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 23 06:13:22 PDT 2015


Thank you. I think I have fixed the issue in r248375.

On Wed, Sep 23, 2015 at 12:25 PM, NAKAMURA Takumi <geek4civic at gmail.com>
wrote:

> chapuni added subscribers: cfe-commits, chapuni.
>
> /cfe/trunk/lib/Tooling/Core/Replacement.cpp:408 FirstI may be in the end()
> when SecondI != end(). Then FirstI->getOffset() is invalid.
>
> I suggest to split the loop into
>   - FirstI != First.end() && SecondI != Second.end();
>   - Tail-merge (either is end())
>
> Users:
>   djasper (Author)
>
> http://reviews.llvm.org/rL248367
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150923/38f805d1/attachment.html>


More information about the cfe-commits mailing list