PATCH: Provide the compile commands of the JSON database in consistent order

Argyrios Kyrtzidis via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 22 10:24:44 PDT 2015


In r248292, the added unit test fails without the changes.

> On Sep 18, 2015, at 5:49 PM, Manuel Klimek via cfe-commits <cfe-commits at lists.llvm.org> wrote:
> 
> LG in general; I think if we like the order to be deterministic we should try to come up with a unit test so nobody regresses this in the future.
> 
> On Fri, Sep 18, 2015 at 4:44 PM Argyrios Kyrtzidis <kyrtzidis at apple.com <mailto:kyrtzidis at apple.com>> wrote:
> Hi,
> 
> I have found it useful for the getAllCompileCommands() to return the commands in the order that they were provided in the JSON file.
> This is useful for debugging of issues and reduction of test cases.
> For example, an issue may show up due to the order that some commands were processed. It is convenient to be able to remove commands from the file and still preserve the order that they are returned, instead of getting a completely different order when removing a few commands.
> 
> Let me know what you think!
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150922/f598c9a0/attachment.html>


More information about the cfe-commits mailing list