[PATCH] D12541: [Sparc][Shave]: Empower the toolchain formerly known as SHAVE to do more.

[James Y Knight via cfe-commits]

jyknight accepted this revision.
jyknight added a comment.
This revision is now accepted and ready to land.

Other than minor comments, lgtm.


================
Comment at: lib/Driver/ToolChains.cpp:3937
@@ +3936,3 @@
+  default:
+    llvm_unreachable("Unsupported architecture");
+  case llvm::Triple::sparc:
----------------
I think you want something like:
 D.Diag(diag::err_target_unsupported_arch) << Triple.getArchName() << "myriad"
since it is expected to be reachable via commandline args.

================
Comment at: test/Driver/shave-toolchain.c:2
@@ +1,3 @@
+// RUN: %clang -no-canonical-prefixes -### -target sparc-myriad-rtems-elf %s \
+// RUN: -B %S/Inputs/basic_myriad_tree 2>&1 | FileCheck %s -check-prefix=LINK_WITH_RTEMS
+// LINK_WITH_RTEMS: crti.o
----------------
Maybe some more check lines on this command, to verify that getCompilerSupportDir and getBuiltinLinkDir are returning useful values.


http://reviews.llvm.org/D12541