[PATCH] D12904: fix for assertion fail for pragma weak on typedef

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 17 07:45:52 PDT 2015


aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM with one minor nit.


================
Comment at: lib/Sema/Sema.cpp:729
@@ +728,3 @@
+      Diag(WeakID.second.getLocation(), diag::warn_attribute_wrong_decl_type)
+          << "weak" << ExpectedVariableOrFunction;
+    else
----------------
Should be "'weak'" instead of "weak" so that the diagnostic is properly quoted for the user.


http://reviews.llvm.org/D12904





More information about the cfe-commits mailing list