[PATCH] D11279: Initial patch for PS4 toolchain

[Eric Christopher via cfe-commits]

echristo added a comment.

In http://reviews.llvm.org/D11279#247377, @kromanova wrote:

> test/Driver/Inputs/scei-ps4_tree/target/include_common/ and  test/Driver/Inputs/scei-ps4_tree/target/include/ are expected to be present by a test ps4-header-search.c. This test checks that these directories are found in the header search path. If these directories are not found, the compiler complains and the test fails.
>  .keep file is needed to keep these directories in place.


How about just a README file in the directories saying this rather than the .keep file? :)

-eric


================
Comment at: lib/Driver/Tools.cpp:10025-10029
@@ +10024,7 @@
+  const char *Exec =
+#ifdef LLVM_ON_WIN32
+      Args.MakeArgString(ToolChain.GetProgramPath("ps4-ld.gold.exe"));
+#else
+      Args.MakeArgString(ToolChain.GetProgramPath("ps4-ld"));
+#endif
+
----------------
kromanova wrote:
> echristo wrote:
> > How does this work with the things below that check for linker name?
> > 
> > Also seems like we'd really want to be able to check our host using the normal ways rather than an ifdef. This can be done as a followup, but do please check into this.
> We will check for the host without the ifdef, but we will do it in a follow-up commit.
> 
> 
> 
That's fine, thanks.


http://reviews.llvm.org/D11279