[PATCH] D12541: [Sparc][Shave]: Empower the toolchain formerly known as SHAVE to do more.

[James Y Knight via cfe-commits]

jyknight added inline comments.

================
Comment at: lib/Driver/ToolChains.cpp:3929
@@ +3928,3 @@
+    : Generic_GCC(D, Triple, Args) {
+  // If a target of 'sparc-myriad-elf' is specified to clang, it wants to use
+  // 'sparc-myriad--elf' (note the unknown OS) as the canonical triple.
----------------
Perhaps report an error if passed a cpu that's not sparc* or shave, since right now it'll get in here, and then just do something bogus?

================
Comment at: lib/Driver/Tools.cpp:9754
@@ +9753,3 @@
+
+  CmdArgs.push_back("-EL"); // Endianness = little
+
----------------
should probably be conditioned on being little endian.

================
Comment at: lib/Driver/Tools.cpp:9792
@@ +9791,3 @@
+    CmdArgs.push_back("--start-group");
+    CmdArgs.push_back("-lg");
+    // You must provide your own "-L" option to enable finding these.
----------------
as discussed, libg and libc are identical, so probably should use -lc here too for consistency.


http://reviews.llvm.org/D12541