[PATCH] D11279: Initial patch for PS4 toolchain

Eric Christopher via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 14 13:07:24 PDT 2015


echristo accepted this revision.
echristo added a comment.

One set of inline comments, and also:

test/Driver/Inputs/scei-ps4_tree/target/include_common/.keep

eh?

-eric


================
Comment at: lib/Driver/Tools.cpp:10025-10029
@@ +10024,7 @@
+  const char *Exec =
+#ifdef LLVM_ON_WIN32
+      Args.MakeArgString(ToolChain.GetProgramPath("ps4-ld.gold.exe"));
+#else
+      Args.MakeArgString(ToolChain.GetProgramPath("ps4-ld"));
+#endif
+
----------------
How does this work with the things below that check for linker name?

Also seems like we'd really want to be able to check our host using the normal ways rather than an ifdef. This can be done as a followup, but do please check into this.


http://reviews.llvm.org/D11279





More information about the cfe-commits mailing list