r247598 - [Static Analyzer] Relaxing a caching out related assert.

Gabor Horvath via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 14 12:00:08 PDT 2015


Author: xazax
Date: Mon Sep 14 14:00:08 2015
New Revision: 247598

URL: http://llvm.org/viewvc/llvm-project?rev=247598&view=rev
Log:
[Static Analyzer] Relaxing a caching out related assert.

Differential Revision: http://reviews.llvm.org/D12818


Modified:
    cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineObjC.cpp

Modified: cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineObjC.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineObjC.cpp?rev=247598&r1=247597&r2=247598&view=diff
==============================================================================
--- cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineObjC.cpp (original)
+++ cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineObjC.cpp Mon Sep 14 14:00:08 2015
@@ -186,8 +186,11 @@ void ExprEngine::VisitObjCMessage(const
 
         // Generate a transition to non-Nil state.
         if (notNilState != State) {
+          bool HasTag = Pred->getLocation().getTag();
           Pred = Bldr.generateNode(ME, Pred, notNilState);
-          assert(Pred && "Should have cached out already!");
+          assert((Pred || HasTag) && "Should have cached out already!");
+          if (!Pred)
+            continue;
         }
       }
     } else {




More information about the cfe-commits mailing list