[PATCH] D12402: PR24595: clang-cl fails to compile vswriter.h header from Windows SDK 8.1 in 32 bit mode

[Reid Kleckner via cfe-commits]

rnk added inline comments.

================
Comment at: lib/Sema/SemaType.cpp:5876
@@ +5875,3 @@
+
+    if (!IsCtorOrDtor) {
+      if (CurCC != DefaultCC || DefaultCC == ToCC)
----------------
andreybokhanko wrote:
> rnk wrote:
> > This looks like the !IsCtorOrDtor check that affects Itanium. Isn't it already handled for MS C++ above?
> Reid, now I'm completely confused... I thought you asked me to insert this check for Itanium ABI as well (in your comment from Sep 1st). Am I mistaken? If yes, I can remove it and restore ctor-dtor-alias.cpp test back to original version.
Sorry, it shouldn't affect Itanium. What you have without this check is fine.


http://reviews.llvm.org/D12402