[PATCH] D12780: [analyzer] Add generateErrorNode() APIs to CheckerContext

[Jordan Rose via cfe-commits]

jordan_rose added inline comments.

================
Comment at: lib/StaticAnalyzer/Checkers/FixedAddressChecker.cpp:53
@@ -52,3 +52,3 @@
 
-  if (ExplodedNode *N = C.addTransition()) {
+  if (ExplodedNode *N = C.generateNonFatalErrorNode()) {
     if (!BT)
----------------
zaks.anna wrote:
> Can this ever fail? In some cases we just assume it won't in others we tests..
> 
> Maybe it only fails when we cache out?
It does fail when we cache out, and I think we can still cache out if Pred has a different tag the second time around.


http://reviews.llvm.org/D12780