r247410 - This test requires UTF-8 output to print the UT-8 characters.

[Yaron Keren via cfe-commits]

The test was passing before r247253 without LLVM_ON_WIN32 defined in
lib/Support/Locale.cpp, so the llvm::sys::unicode::* functions were used,
which may mean that the LLVM_ON_WIN32 functions are overly restrictive.
For example, Windows can output the UTF-8 character from source-col-map.c
correctly. Maybe the correct fix it to actually eliminate the
LLVM_ON_WIN32 versions.

What I still don't understand - how the Windows bots were passing this test
and green?


2015-09-11 16:31 GMT+03:00 Aaron Ballman <aaron at aaronballman.com>:

> Thank you for this! I wasn't certain of what the right way to fix it was.
> :-)
>
> ~Aaron
>
> On Fri, Sep 11, 2015 at 9:29 AM, Yaron Keren via cfe-commits
> <cfe-commits at lists.llvm.org> wrote:
> > Author: yrnkrn
> > Date: Fri Sep 11 08:29:12 2015
> > New Revision: 247410
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=247410&view=rev
> > Log:
> > This test requires UTF-8 output to print the UT-8 characters.
> >
> >
> > Modified:
> >     cfe/trunk/test/Frontend/source-col-map.c
> >
> > Modified: cfe/trunk/test/Frontend/source-col-map.c
> > URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Frontend/source-col-map.c?rev=247410&r1=247409&r2=247410&view=diff
> >
> ==============================================================================
> > --- cfe/trunk/test/Frontend/source-col-map.c (original)
> > +++ cfe/trunk/test/Frontend/source-col-map.c Fri Sep 11 08:29:12 2015
> > @@ -1,4 +1,5 @@
> >  // RUN: not %clang_cc1 -fsyntax-only -fmessage-length 75 -o /dev/null
> -x c < %s 2>&1 | FileCheck %s -strict-whitespace
> > +// REQUIRES: utf8-capable-terminal
> >
> >  // Test case for the text diagnostics source column conversion crash.
> >
> >
> >
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150911/a8884902/attachment.html>