[PATCH] D12652: [Static Analyzer] Lambda support.

[Jordan Rose via cfe-commits]

jordan_rose added a comment.

A  few comments coming late…


================
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:515-517
@@ -511,1 +514,5 @@
 
+  /// Returns true if lambdas should be inlined. Otherwise a sink node will be
+  /// generated each time a LambdaExpr is visited.
+  bool shouldInlineLambdas();
+
----------------
"inline" is kind of a misnomer, since we may not actually inline lambdas. I would have suggested "model lambdas" or "lambda support".

================
Comment at: lib/StaticAnalyzer/Core/MemRegion.cpp:740-741
@@ -739,3 +739,4 @@
                                       const DeclContext *DC,
-                                      const VarDecl *VD) {
+                                      const VarDecl *VD,
+                                      MemRegionManager *Mmgr) {
   while (LC) {
----------------
Why the extra parameter?


http://reviews.llvm.org/D12652