[PATCH] D12712: Implementation and testing for poisoning vtable ptr in dtor.

[Evgeniy Stepanov via cfe-commits]

eugenis added inline comments.

================
Comment at: lib/CodeGen/CGClass.cpp:1652
@@ +1651,3 @@
+
+ static void Poison(CodeGenFunction &CGF, llvm::Value *OffsetPtr,
+                    CharUnits::QuantityType PoisonSize);
----------------
nmusgrave wrote:
> eugenis wrote:
> > If it's a global function, it should have a more descriptive name, like EmitSanitizerDtorCallback.
> > OffsetPtr => just Ptr
> > And move the body of the function to this line to avoid unnecessary redeclaration.
> It's inside of a namespace- is it still global?
In a sense. This namespace is not only about sanitizers, so Poison is ambiguous.


http://reviews.llvm.org/D12712