[PATCH] D12402: PR24595: clang-cl fails to compile vswriter.h header from Windows SDK 8.1 in 32 bit mode

[Reid Kleckner via cfe-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm, thanks!


================
Comment at: test/CodeGenCXX/ctor-dtor-alias.cpp:170
@@ -169,3 +169,3 @@
   // it has a different calling conversion.
-  // CHECK4: call void @_ZN5test93barD2Ev
+  // CHECK4: call void @_ZN6test103barD2Ev
   bar ptr;
----------------
Isn't this still in the test9 namespace? Shouldn't this change be reverted?

================
Comment at: test/CodeGenCXX/microsoft-abi-structors.cpp:411
@@ -410,3 @@
-
-// FIXME: This should be x86_thiscallcc.  MSVC ignores explicit CCs on structors.
-// CHECK: define %"struct.test1::B"* @"\01??0B at test1@@QAA at PAF@Z"
----------------
Hah, looks like we encountered this long ago and didn't go back for it. :)


http://reviews.llvm.org/D12402