[PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

Igor Kudrin via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 10 11:38:30 PDT 2015


ikudrin added a comment.

In http://reviews.llvm.org/D12695#243552, @rnk wrote:

> There's a bunch of whitespace issues that clang-format can resolve.


Thanks! I'll reformat it.

> We also have the convention that variables are StudlyCaps, which isn't followed in a few places.


I've tried to follow the style of the source file. Do you think I should force this rule here?

> Do you need someone to commit this for you? If so, I can patch this in, test it manually, and deal with the style stuff if you deal with the VSDir part.


I'd really appreciate it. I'll prepare a new version in a few minutes.


http://reviews.llvm.org/D12695





More information about the cfe-commits mailing list