[PATCH] D12769: [analyzer] Update SATestBuild.py to set -isysroot for preprocessed files

Devin Coughlin via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 10 11:26:56 PDT 2015


dcoughlin added inline comments.

================
Comment at: utils/analyzer/SATestBuild.py:277
@@ +276,3 @@
+    # For now, we assume the preprocessed files should be analyzed
+    # with the OS X SDK.
+    SDKPath = getSDKPath("macosx")
----------------
xazax.hun wrote:
> dcoughlin wrote:
> > xazax.hun wrote:
> > > I think it might be better to check if the host os is OS X. This way one might be able to check preprocessed files on other linux.
> > The patch checks for the existence of xcrun in the path and doesn't set -isysroot if that is not present, so this should continue to work on Linux and cygwin.
> I see, however -cc1 option is only used when the SDKPath is not None. Is this intended?
No, you're right -- that is not intended.


http://reviews.llvm.org/D12769





More information about the cfe-commits mailing list