[PATCH] D12712: Implementation and testing for poisoning vtable ptr in dtor.

Evgeniy Stepanov via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 9 12:42:45 PDT 2015


eugenis added inline comments.

================
Comment at: lib/CodeGen/CGClass.cpp:1685
@@ +1684,3 @@
+        // function
+        Poison(CGF, VTablePtr, PoisonSize);
+      }
----------------
Did you mean to move this chunk to the other cleanup class?
Is there a test that would fail if vptr is prematurely poisoned? There should be one (it's ok if it is only in compiler-rt, this could be hard to test with lit over IR).



http://reviews.llvm.org/D12712





More information about the cfe-commits mailing list