[PATCH] D12358: [Analyzer] Handling constant bound loops

[Devin Coughlin via cfe-commits]

Hi Sean,

Ted provided more details off-list. He suspects that the problem is that we likely don't add MemSpaceRegions to the worklist because every region is a subregion of a MemSpaceRegion, and thus we would invalidate, by default, all regions that were in the same MemSpace as the regions we were invalidating.  He thinks we want to not change that behavior, but also provide a way of invalidating an entire MemSpace if so desired.  That's probably just a slight tweak to the algorithm.

I’ll take a look at your updated patch to reproduce what you are seeing and investigate to see if that is what is going on.

Thanks,
Devin


> On Sep 2, 2015, at 11:20 PM, Ted Kremenek <kremenek at apple.com> wrote:
> 
> krememek added a comment.
> 
> In https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D12358-23238303&d=BQIFaQ&c=eEvniauFctOgLOKGJOplqw&r=DnBGy2nbxhNDknO0DK0VCbUffuO8dI0aqN61uD3KzUU&m=csFsFfIgmsGT7Ht2XuvhMyNifot56bO04tnwaGZNFTY&s=LUjlFLLnrJD-ZC-sWeh6j7eL9EEhYUHMbmP_6QTJrxg&e= , @seaneveson wrote:
> 
>> In https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D12358-23237099&d=BQIFaQ&c=eEvniauFctOgLOKGJOplqw&r=DnBGy2nbxhNDknO0DK0VCbUffuO8dI0aqN61uD3KzUU&m=csFsFfIgmsGT7Ht2XuvhMyNifot56bO04tnwaGZNFTY&s=R8WzaxQRbHMf18_Ovjwx0V-l-
>> 
>> Do you have any suggestions on what I have done wrong?
> 
> I suspect this has to do with `invalidateRegions` itself.  I will take a look.  In the meantime, can you provide an updated patch that I can try out so I can step through the algorithm (if necessary) in the debugger and reproduce what you are seeing?