[PATCH] D12646: Add libc++ header path for DarwinClang builds

don hinton via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 8 09:29:07 PDT 2015


hintonda added a comment.

In http://reviews.llvm.org/D12646#241493, @bob.wilson wrote:

> On Darwin platforms, the libc++ headers are expected to be installed alongside clang. If you're not doing that, then you're building it wrong. Adding more fallback options for finding the headers just makes things worse, because instead of a clear failure, you're more likely to get something that works but behaves badly in a subtle way (e.g., due to using really old libc++ headers).
>
> I don't think this is the right thing to do.


Okay, I'm comfortable with this solution.  I'll work up a diff that makes cmake fail if libc++ isn't included in the build.


http://reviews.llvm.org/D12646





More information about the cfe-commits mailing list