[PATCH] D6964: [libcxx] SFINAE-friendly common_type

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 7 16:48:45 PDT 2015


EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

LGTM. I don't know why I've been putting this off for so long.

There is still some contention over weither common_type should apply "decay" to every result or just the last one. This patch applies it to every result as does the current implementation.
For that reason I think this is a strict improvement.

@K-ballo May I commit this with a couple of small changes? I want to fully qualify all of the calls to "declval<Tp>(...)".


http://reviews.llvm.org/D6964





More information about the cfe-commits mailing list