[PATCH] D12675: Avoid using rvalue references with trivially copyable types.

[Angel Garcia via cfe-commits]

angelgarcia marked 3 inline comments as done.

================
Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:658-663
@@ -646,7 +657,8 @@
+      IsTriviallyCopyable = BeginPointeeType.isTriviallyCopyableType(*Context);
     } else {
       // Check for qualified types to avoid conversions from non-const to const
       // iterator types.
       if (!Context->hasSameType(CanonicalInitVarType, CanonicalBeginType))
         return;
     }
 
----------------
klimek wrote:
> Can you add a comment what FixerKind is in the else, so it's obvious why we don't want to do anything else in here?
What do you mean? We're still inside the "if (FixerKind == LFK_Iterator)".


http://reviews.llvm.org/D12675