[PATCH] D12512: [libcxxabi] Manually align pointers in __cxa_allocate_exception - Fixes PR24604

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 4 14:28:39 PDT 2015


EricWF added a comment.

In http://reviews.llvm.org/D12512#237175, @joerg wrote:

> Please don't commit this as is. Many platforms have posix_memalign or equivalent, which makes this both simpler and potentially without wasting memory. Compare e.g. http://reviews.llvm.org/D12001.


Will do. Any advice on detecting posix_memalign? I don't see anything in the patch you pointed me to.

PS. Thanks for actually rejecting the patch. It makes the phab workflow easier to use.


http://reviews.llvm.org/D12512





More information about the cfe-commits mailing list