[PATCH] D12400: Fix store detection for return value in CGCall
Arnaud de Grandmaison via cfe-commits
cfe-commits at lists.llvm.org
Wed Sep 2 06:06:55 PDT 2015
aadg added a comment.
Yet another comment (see below).
================
Comment at: lib/CodeGen/CGCall.cpp:2332
@@ -2331,2 +2331,3 @@
if (!store) return nullptr;
+ if (store->getPointerOperand() != CGF.ReturnValue) return nullptr;
----------------
aadg wrote:
> It might be worth stating in a comment why this is needed --- for the benefit of people who will read this code later.
I also note that those lines are looking very much like those in the if above (handling the multiple use of the return value case)... This issue was fixed above, but not here. Would it be possible to avoid code duplication ?
Repository:
rL LLVM
http://reviews.llvm.org/D12400
More information about the cfe-commits
mailing list