Move createEliminateAvailableExternallyPass earlier

Yaron Keren via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 2 00:02:46 PDT 2015


r246619, thanks!
About createEliminateAvailableExternallyPass for LTO, I'm missing
something. At link time, aren't available externally function supposed to
be, well, available as external linkage? Won't the link fail without these
versions?
if so, why keep the available externally versions at all for LTO instead of
using the external linkage versions?


2015-09-01 23:56 GMT+03:00 Teresa Johnson <tejohnson at google.com>:

> Hi Yaron,
>
> Thanks, moving it earlier in general seems ok to me. I originally put
> this right before the GlobalDCE calls because it was somewhat related.
> I wonder if the createEliminateAvailableExternallyPass call for the
> LTO pipeline should similarly be moved up closer to inlining, perhaps
> after any IP alias analysis passes? Hopefully someone more familiar
> with the passes than I will comment on how early we can do this.
>
> Teresa
>
> On Tue, Sep 1, 2015 at 1:32 PM, Yaron Keren via cfe-commits
> <cfe-commits at lists.llvm.org> wrote:
> > Following the discussion on cfe-dev, this moves
> > createEliminateAvailableExternallyPass earlier in the pass pipeline to
> save
> > running many ModulePasses on available external functions that are thrown
> > away anyhow.
> >
> >
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
> >
>
>
>
> --
> Teresa Johnson | Software Engineer | tejohnson at google.com | 408-460-2413
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150902/43d83d78/attachment-0001.html>


More information about the cfe-commits mailing list