[PATCH] D11963: Create a __config_site file to capture configuration decisions.

Evgeniy Stepanov via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 1 16:01:51 PDT 2015


eugenis added a subscriber: eugenis.
eugenis added a comment.

This would greatly simplify the abi versioning change in http://reviews.llvm.org/D11740. Thanks for working on this!


================
Comment at: include/CMakeLists.txt:24
@@ +23,3 @@
+  -P ${LIBCXX_SOURCE_DIR}/cmake/Modules/CopyLibcxxHeaders.cmake
+  WORKING_DIRECTORY ${CMAKE_CURRENT_LIST_DIR})
+
----------------
This is creative :)
I don't know the usual cmake conventions, but CopyLibcxxHeaders is very different from other files in cmake/Modules in that it is a standalone script and not an included file. Should it be moved to smth like cmake/Scripts, or named differently?



http://reviews.llvm.org/D11963





More information about the cfe-commits mailing list