[PATCH] D12402: PR24595: clang-cl fails to compile vswriter.h header from Windows SDK 8.1 in 32 bit mode

Andrey Bokhanko via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 1 05:18:57 PDT 2015


andreybokhanko updated this revision to Diff 33678.
andreybokhanko added a comment.

Reid, thanks for looking into this!

As I discovered, MS compiler transforms __stdcall to __thiscall for all structors (not only virtual ones) in 32 bit mode. In 64 bit mode, it transforms __stdcall to __cdecl for everything.

Clang already does the same in 64 bit mode; my updated patch makes us transform __stdcall to __thiscall for structors in 32 bit mode in MSVC environment.

Please re-review.

Yours,
Andrey


http://reviews.llvm.org/D12402

Files:
  include/clang/Sema/DeclSpec.h
  include/clang/Sema/Sema.h
  lib/Sema/DeclSpec.cpp
  lib/Sema/SemaDecl.cpp
  lib/Sema/SemaType.cpp
  test/CodeGenCXX/microsoft-abi-structors.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D12402.33678.patch
Type: text/x-patch
Size: 5951 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150901/bc01cbc1/attachment-0001.bin>


More information about the cfe-commits mailing list