[PATCH] D12512: [libcxxabi] Manually align pointers in __cxa_allocate_exception - Fixes PR24604

[Saleem Abdulrasool via cfe-commits]

compnerd added a comment.

While I can see the argument you raise, the saving grace here is that this is buried in libc++abi.  The only real piece of libc++abi of real use to users is `__cxa_demangle` (which is only relevant for Windows, and Darwin where you have two level namespaces).  For everyone else, libc++abi is merely an implementation detail for libc++ and will not be linked to directly.  If you are mixing and matching the ABI support interfaces, or the runtime, you are already in a pretty bad shape, and allowing things to break in such a circumstances doesn't seem entirely terrible.  Unfortunately, for compatibility with GCC, we do need to maintain this alignment, which is not guaranteed without this patch.


http://reviews.llvm.org/D12512