r246468 - Pull the target attribute parsing out of CGCall and onto TargetInfo.

[Eric Christopher via cfe-commits]

Aha. This is what's causing Siva Chandra's problem.

Hrm, I'll see what I can figure out. I'll revert until then or talk to
Richard.

-eric

On Mon, Aug 31, 2015 at 4:02 PM Hans Wennborg <hans at chromium.org> wrote:

> This change makes Basic depend on AST.
>
> The immediate problem I'm hitting is clang-format (which uses Basic
> but not AST) failing to link on Windows [1], but I suspect this could
> cause problems elsewhere too.
>
> Is there some way to avoid this dependency?
>
>  [1].
> http://build.chromium.org/p/chromium.fyi/builders/ClangToTWin/builds/2903/steps/gclient%20runhooks/logs/stdio
>
> On Mon, Aug 31, 2015 at 11:39 AM, Eric Christopher via cfe-commits
> <cfe-commits at lists.llvm.org> wrote:
> > Author: echristo
> > Date: Mon Aug 31 13:39:22 2015
> > New Revision: 246468
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=246468&view=rev
> > Log:
> > Pull the target attribute parsing out of CGCall and onto TargetInfo.
> >
> > Also:
> >   - Add a typedef to make working with the result easier.
> >   - Update callers to use the new function.
> >   - Make initFeatureMap out of line.
> >
> > Modified:
> >     cfe/trunk/include/clang/Basic/TargetInfo.h
> >     cfe/trunk/lib/Basic/TargetInfo.cpp
> >     cfe/trunk/lib/CodeGen/CGCall.cpp
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150831/59a17845/attachment-0001.html>