[PATCH] D12462: [PATCH] [clang-tidy] Add inconsistent declaration parameter name check

Piotr Dziwinski via cfe-commits cfe-commits at lists.llvm.org
Sun Aug 30 03:41:17 PDT 2015


piotrdz removed rL LLVM as the repository for this revision.
piotrdz updated this revision to Diff 33527.
piotrdz added a comment.

I noticed a few things I should have done better:

- use std::set instead of std::unordered_set (it doesn't seem to be used elsewhere)
- move checking set of reported functions to just before emitting diagnostic
- improved documentation
- changed diff directory to inside clang-tools-extra repository


http://reviews.llvm.org/D12462

Files:
  clang-tidy/readability/CMakeLists.txt
  clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp
  clang-tidy/readability/InconsistentDeclarationParameterNameCheck.h
  clang-tidy/readability/ReadabilityTidyModule.cpp
  docs/clang-tidy/checks/list.rst
  docs/clang-tidy/checks/readability-inconsistent-declaration-parameter-name.rst
  test/clang-tidy/readability-inconsistent-declaration-parameter-name.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D12462.33527.patch
Type: text/x-patch
Size: 10944 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150830/3e2b83c1/attachment-0001.bin>


More information about the cfe-commits mailing list