[PATCH] D11297: PR17829: Functions declared extern "C" with a name matching a mangled C++ function are allowed

[John McCall via cfe-commits]

rjmccall added a comment.

This looks great, thanks!  One last comment; if you agree with me, go ahead and fix it and then commit.


================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2323
@@ -2323,1 +2322,3 @@
+  "definition with same mangled name as another definition">,
+  InGroup<DuplicateMangledNames>;
 def err_cyclic_alias : Error<
----------------
I'm sorry to bring this up so late in the process, but is there a good reason for this to be a warning and not an error?


http://reviews.llvm.org/D11297