[PATCH] D11380: Implement LFTS searchers. Boyer_Moore and Boyer_Moore_Horspool

Marshall Clow via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 27 19:40:05 PDT 2015


mclow.lists added a comment.

Two comments answered. One still remaining.


================
Comment at: include/experimental/functional:256
@@ +255,3 @@
+        
+public: // TODO private:
+    _RandomAccessIterator1 __first_;
----------------
EricWF wrote:
> Is this for testing?
Well, for debugging. My first comment addressed this (basically, it will get changed).

================
Comment at: include/experimental/functional:313
@@ +312,3 @@
+
+    void build_suffix_table(_RandomAccessIterator1 __f, _RandomAccessIterator1 __l, 
+                                                    _BinaryPredicate __pred)
----------------
EricWF wrote:
> This needs to be a reserved identifier right?
You are correct.


http://reviews.llvm.org/D11380





More information about the cfe-commits mailing list