[PATCH] D12355: [libcxx] Optimize away unneeded length calculation in basic_string::compare(const char*)

Marshall Clow via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 27 19:35:39 PDT 2015


mclow.lists added a comment.

The first change LGTM. The second one needs to match it.


================
Comment at: include/string:3816
@@ -3808,2 +3815,3 @@
+    return __lhs.compare(0, _String::npos, __rhs, __rhs_len) == 0;
 }
 
----------------
You'll want to do the same as above here.


http://reviews.llvm.org/D12355





More information about the cfe-commits mailing list