[PATCH] D12247: [libc++] remove possible trailing padding from aligned_storage

Yiran Wang via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 27 14:57:36 PDT 2015


yiranwang added a comment.

In http://reviews.llvm.org/D12247#234533, @EricWF wrote:

> So this patch LGTM. Sorry for being slow to understand it. However I want to see two things before it lands.
>
> 1. I would like to see a test of some sort that the resulting type has the same size and alignment requirements it did before the change. I'm not sure what the best way to test this is.
> 2. I would like @mclow.lists to approve this as well. I just want to be cautious.


I think now we are on the same page about these bugs. 
Also, thanks for your review and findings (hopefully fix it soon too).

For the test, we compile it with -O3 -fstrict-aliasing -finline-limit=300, and as mentioned before the target is AARCH64+ANDROID.


http://reviews.llvm.org/D12247





More information about the cfe-commits mailing list