[PATCH] D11844: [Modules] More descriptive diagnostics for misplaced import directive

[Serge Pavlov via cfe-commits]

Ping.

Thanks,
--Serge

2015-08-22 3:15 GMT+06:00 Sean Silva <chisophugis at gmail.com>:

> silvas added inline comments.
>
> ================
> Comment at: test/Modules/auto-module-import.m:89
> @@ +88,3 @@
> +                              expected-error {{import of module
> 'NoUmbrella.A' appears within function 'includeNotAtTopLevel'}} \
> +                              expected-note {{consider marking the module
> as textual}}
> +}
> ----------------
> I think what this means is marking the *header* as textual. So I would
> suggest the wording "consider marking the header as textual".
>
>
> http://reviews.llvm.org/D11844
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150827/d8152381/attachment.html>