[PATCH] D12169: Relax constexpr rules to improve __builtin_object_size's accuracy

George Burgess IV via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 25 13:02:05 PDT 2015


george.burgess.iv updated this revision to Diff 33104.
george.burgess.iv added a comment.

Talked with Richard, and we both agree that adding 4 EvaluationModes is too much for the use case. So, we decided to add a flag to LValue to denote that the LValueBase is invalid. This allows us to get by with just 2 new EvaluationModes, which is much more acceptable.

LValueBases can only be invalid if you're using one of the shiny new EvaluationModes.


http://reviews.llvm.org/D12169

Files:
  lib/AST/ExprConstant.cpp
  test/CodeGen/object-size.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D12169.33104.patch
Type: text/x-patch
Size: 24726 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150825/a451e2fe/attachment-0001.bin>


More information about the cfe-commits mailing list