[PATCH] D12312: Emiting invariant.group.barrier and adding -fstrict-vptrs

John McCall via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 25 12:10:18 PDT 2015


rjmccall added a comment.

You should add a test that actually checks that your feature works.


================
Comment at: lib/CodeGen/CGClass.cpp:1279
@@ +1278,3 @@
+  if (CGM.getCodeGenOpts().StrictVPtrs && BaseVPtrsInitialized)
+    CXXThisValue = Builder.CreateInvariantGroupBarrier(LoadCXXThis());
+
----------------
Should this just be in InitializeVTablePointers?


http://reviews.llvm.org/D12312





More information about the cfe-commits mailing list