[PATCH] D12209: [libcxx] Remove installation rules on Darwin when it would overwrite the system installation.

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 25 12:06:28 PDT 2015


EricWF added inline comments.

================
Comment at: CMakeLists.txt:105
@@ +104,3 @@
+if (${CMAKE_SYSTEM_NAME} MATCHES "Darwin" AND NOT LIBCXX_OVERRIDE_DARWIN_INSTALL)
+  if ("${CMAKE_INSTALL_PREFIX}" STREQUAL "/usr")
+    message(WARNING "Disabling libc++ install rules because installation would "
----------------
jroelofs wrote:
> I would check for "/usr/" too.
CMake canonicalizes `CMAKE_INSTALL_PREFIX` which includes removing the trailing slash. I tested this before submitting the patch.


http://reviews.llvm.org/D12209





More information about the cfe-commits mailing list