[PATCH] D12265: [ZORG] Add support for libc++ to SphinxDocBuilder.py

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 24 17:35:15 PDT 2015


EricWF accepted this revision.
EricWF added a reviewer: EricWF.
EricWF added a comment.
This revision is now accepted and ready to land.

Accepting so I can commit.


================
Comment at: buildbot/osuosl/master/config/builders.py:1166
@@ +1165,3 @@
+               'name':"libcxx-sphinx-docs",
+               'slavenames':["ericwf-buildslave2],
+               'builddir':"libcxx-sphinx-docs",
----------------
delcypher wrote:
> Is there a reason you're using the slave `ericwf-buildslave2` rather than `gribozavr4` which is used by the other documentation builders?
> 
> 
I have my own hardware that I might as well use. I wanted to keep gribozavr's hardware as free as possible in case other people need it.

================
Comment at: buildbot/osuosl/master/config/builders.py:1341
@@ -1333,3 +1340,3 @@
  'factory' : LNTBuilder.getLNTFactory(triple='x86_64-apple-darwin10',
-                                      nt_flags=['--multisample=3', 
+                                      nt_flags=['--multisample=3',
                                                 '--optimize-option',
----------------
delcypher wrote:
> This spacing change doesn't really belong in this patch
I know :-( but for some reason my editor refused to leave it out. 


http://reviews.llvm.org/D12265





More information about the cfe-commits mailing list