[PATCH] D12265: [ZORG] Add support for libc++ to SphinxDocBuilder.py

[Dan Liew via cfe-commits]

delcypher added a comment.

The rest LGTM


================
Comment at: buildbot/osuosl/master/config/builders.py:1166
@@ +1165,3 @@
+               'name':"libcxx-sphinx-docs",
+               'slavenames':["ericwf-buildslave2],
+               'builddir':"libcxx-sphinx-docs",
----------------
Is there a reason you're using the slave `ericwf-buildslave2` rather than `gribozavr4` which is used by the other documentation builders?



================
Comment at: buildbot/osuosl/master/config/builders.py:1341
@@ -1333,3 +1340,3 @@
  'factory' : LNTBuilder.getLNTFactory(triple='x86_64-apple-darwin10',
-                                      nt_flags=['--multisample=3', 
+                                      nt_flags=['--multisample=3',
                                                 '--optimize-option',
----------------
This spacing change doesn't really belong in this patch

================
Comment at: zorg/buildbot/builders/SphinxDocsBuilder.py:13
@@ -13,1 +12,3 @@
+        lld_html    = False, # Build LLD HTML documentation
+        libcxx_html = False # Build Libc++ HTML documentation
         ):
----------------
Minor nit, the ``#`` should probably be horizontally aligned with the others


http://reviews.llvm.org/D12265