[PATCH] D12244: Implement ACLE 2.0 macros of chapters 6.4 and 6.5 for [ARM] and [Aarch64] targets

[Renato Golin via cfe-commits]

rengolin added a comment.

I'm surprised you decided to rearrange the output of the macros. It makes reviewing a lot harder. Is there some special reason to have that in any specific order?


================
Comment at: lib/Basic/Targets.cpp:4621
@@ -4586,1 +4620,3 @@
+    Builder.defineMacro("__REGISTER_PREFIX__", ""); 
+    Builder.defineMacro("__ARM_ARCH_" + CPUAttr + "__");
 
----------------
Is it truly impossible for CPUAttr to be empty? Or just coincidental given our tests?


http://reviews.llvm.org/D12244